D7974: merge: when rename was made on both sides, use ancestor as merge base
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Thu Jan 30 10:29:25 EST 2020
martinvonz added a comment.
In D7974#118685 <https://phab.mercurial-scm.org/D7974#118685>, @martinvonz wrote:
> In D7974#118682 <https://phab.mercurial-scm.org/D7974#118682>, @pulkit wrote:
>
>> `test-rename-merge1.t` fails with this patch. Looks like there is one more instance of prompt which is not needed anymore. I didn't amend that in flight as I was not sure.
>
> I'm pretty sure it's flaky for some reason. Augie also mentioned that that test failed on one of my patches. I ran it 100 times with different python hashes and it never failed for me. I don't know why it behaves differently sometimes. I'm not even sure it started failing with this patch. Does it fail consistently on this one for you? Does it pass consistently on @?
Oh, and note that `--runs-per-test=100` will run the test 100 times with the *same* python hash.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7974/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7974
To: martinvonz, #hg-reviewers, durin42, pulkit
Cc: durin42, marmoute, mercurial-devel
More information about the Mercurial-devel
mailing list