[PATCH 2 of 4] Fix up walk and changes code
Matt Mackall
mpm at selenic.com
Mon Aug 1 13:26:10 CDT 2005
On Mon, Aug 01, 2005 at 11:22:28AM -0700, Bryan O'Sullivan wrote:
> On Mon, 2005-08-01 at 19:03 +0200, Thomas Arendsen Hein wrote:
> > * Thomas Arendsen Hein <thomas at intevation.de> [20050801 07:51]:
> > > * Bryan O'Sullivan <bos at serpentine.com> [20050801 04:10]:
> > > > (c, a, d, u) = repo.changes(files = files, match = matchfn)
> > > > - (c, a, d, u) = map(lambda x: relfilter(repo, x), (c, a, d, u))
> > > > + (c, a, d, u) = [map(lambda x: pathto(cwd, x), n) for n in c, a, d, u]
> > >
> > > Huh, this looks like apples and pears on a cherry tree :)
> >
> > * Bryan O'Sullivan <bos at serpentine.com> [20050801 16:44]:
> > > I know, but I kept the style the same as the line of code I replaced.
> >
> > No, you added apples (list comrehension) to the pear-cherry-tree :)
> >
> > [map(foo, n) for n in c, a, d, u] instead of map(foo, (c, a, d, u))
>
> I'm sorry, I still don't understand what you're trying to say.
He's saying you're mixing the old style (map) with the new style (list
comprehensions).
--
Mathematics is the supreme nostalgia of our time.
More information about the Mercurial
mailing list