[PATCH] Reduce amount of stat traffic generated by dodiff

Chris Mason mason at suse.com
Fri Aug 5 11:06:02 CDT 2005


On Wednesday 03 August 2005 13:13, Bryan O'Sullivan wrote:
> On Wed, 2005-08-03 at 10:50 -0400, Chris Mason wrote:
> > Thanks a lot for working on this.  It looks like we're still doing the
> > stats with the code in hg tip though:
> >
> > strace hg diff Makefile
>
> Ah, right.  The problem was that we were not passing a match function to
> dodiff, so its call to repo.changes was doing an os.stat on everything.

Thanks, the stat count is now normal again ;)  hg diff is still slower than 
before, but I'll adapt my patch to eliminate the copy of the dirstate match 
to your current code and see if that helps.

-chris


More information about the Mercurial mailing list