hg remove implicit for whole tree commits?

[Thomas Arendsen Hein]

* Robin Farine <robin.farine at terminus.org> [20050808 10:33]:
> I see two vestiges from the old code (comments below), could you
> crosscheck?
> 
> >       if fn in dc:
> >         c = dc[fn]
> >         del dc[fn]
> 
> Since you now handle !-files explicitely, the 'del dc[fn]' can
> be either removed or you could verify that dc is empty before
> returning (and raise a software error exception if not).

The del probably isn't needed, I'll check.

> > -      else:
> > -        if match(fn): unknown.append(fn)
> > +      elif s and match(fn):
> 
> Here we have an fn that is not in dc, so doesn't the walk() code
> already ensure the match(fn) condition?

I have just used the old code here to not break anything, but I
looked at this with suspicion, too.

Bryan, what do you think?

Thomas

-- 
Email: thomas at intevation.de
http://intevation.de/~thomas/