hg status issue on windows with tip?

Stephen Darnell sdarnell at esmertec.com
Thu Aug 11 10:13:33 CDT 2005


> On Thu, 2005-08-11 at 11:03 +0100, Stephen Darnell wrote:
> 
> > I have fixes for the new walking code (patch attached).
> 
> Thanks for doing the work.  Are you sure they're complete?

I may have missed a case that's letting a backslash through,
but I don't think so.  The main problem was that os.path.normpath()
converts / to \ on windows as well as doing the .. replacement.

So I essentially wrapped any uses with util.pconvert().

There were some other uses of os.sep which is clearly wrong
when the filenames are in hg canonical form (forward slashes).

> They need to handle names like foo\..\bar sensibly, for 
> example.

I've not changed the uses of normpath which fixes the .. etc. up,
but there may obviously be other cases where normpath is needed
(even on unix).

> I can't clearly see that they ought to work from 
> inspecting the changes.
> 
> 	<b

I'm fallable like everyone else, so I may have made a mistake,
but things are certainly a lot better on Windows.

Regards,
  Stephen



More information about the Mercurial mailing list