[PATCH] hg: added --ssh to specify which SSH binary to use

Perez-Gonzalez, Inaky inaky.perez-gonzalez at intel.com
Fri Aug 19 12:25:20 CDT 2005


>From: Matt Mackall [mailto:mpm at selenic.com]
>
>I'd rather have this use -e than -S in keeping with rsync and friends.

ACK, makes a lot of sense.

>Also, calling repo.ui.config("ui", "ssh", "ssh") to get the default is
>probably a good idea.

I'll check on that--where should I hook for it?

>> @@ -1403,6 +1405,7 @@
>>                ('q', 'quiet', None, 'quiet mode'),
>>                ('', 'profile', None, 'profile'),
>>                ('R', 'repository', "", 'repository root directory'),
>> +              ('S', 'ssh', "ssh", 'SSH command to use'),
>>                ('', 'traceback', None, 'print traceback on
exception'),
>>                ('y', 'noninteractive', None, 'run
non-interactively'),
>>                ('', 'version', None, 'output version information and
>> exit'),
>
>These are the global options. You should make this specific to push.

Ok, I'll work on that too

>
>>  def dispatch(args):
>> +    global ssh_command
>
>Eep!

As I said, I know nothing of python and I was hatching my way
through. What would be the proper way to do it?

>> --- a/mercurial/hg.py	Thu Aug 18 02:52:27 2005
>> +++ b/mercurial/hg.py	Thu Aug 18 20:22:38 2005
>[...]
>> +import commands
>
>Eep! It'd be better to pass a set of options when creating a repo
object.

Links to the the previous.

I won't have time to redo the hack until next week. I'll need more 
help on getting it right :)

Thanks,

-- Inaky



More information about the Mercurial mailing list