Tarball support v0.2

Matt Mackall mpm at selenic.com
Sat Aug 20 14:23:37 CDT 2005


On Sat, Aug 20, 2005 at 06:27:46PM +0200, Wojciech Milkowski wrote:
> Goffredo Baroncelli wrote:
> >You can obtain the changeset hash by the revision number via
> >changelog.node(rev)
> 
> Yes, that was the point - thanks.
> I've rewritten a little that code to meet first Bryan proposal of naming 
> convention, and to move unnecessary string concatenation out of loops.
> 
...
> +        cnode = hex(self.repo.changelog.node(rev))[:12]

Please use short rather than hex. Then you don't need to trim it.

I've just noticed that you're using temp files. I suppose that's
required with .zip, but it should be possible to stream tar.gz files.
That has the advantage that you don't have to wait a minute before
sending starts and you don't have to have extra disk space.

-- 
Mathematics is the supreme nostalgia of our time.


More information about the Mercurial mailing list