tarball support v0.3

Jeff Sipek jeffpc at optonline.net
Thu Aug 25 18:32:16 CDT 2005


On Fri, Aug 26, 2005 at 12:44:59AM +0200, Wojciech Milkowski wrote:
> Jeff Sipek wrote:
> >Yuck! Use templates, eg.
> 
> Fixed, and cleaned up.

Looks good - just few comments, nothing major.

> BTW did you read that: 
> http://www.schneier.com/blog/archives/2005/08/new_cryptanalyt.html

Yes, old news. It doesn't really mean anything for mercurial. 

> +            #if type == "gz":
> +            #    tf = tarfile.TarFile.gzopen('', 'w', sys.stdout, compressionlevel)
> +            #else:
> +            #    tf = tarfile.TarFile.bz2open('', 'w', sys.stdout, compressionlevel)
> +            tf = tarfile.TarFile.open(mode='w|' + type, fileobj=sys.stdout)

Any reason for the commented out code?
 
Also, I used the patch on Matt's latest version 9344f5dd4488, and I get
0 byte bz2 archives. gz and zip work fine.

Jeff.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://www.selenic.com/pipermail/mercurial/attachments/20050825/ae1aea17/attachment.pgp


More information about the Mercurial mailing list