[PATCH] faster directory walking

Bryan O'Sullivan bos at serpentine.com
Fri Aug 26 13:25:20 CDT 2005


On Fri, 2005-08-26 at 13:33 -0400, Chris Mason wrote:

> I reworked the walking patch last night, it is slightly faster then
> before and somewhat cleaner.

This looks nice.  I have no structural problems with it, but I still
have a few requests for you before you hand it off to Matt.

Can you test it with inputs like "hg debugwalk foo* foo*", i.e. repeated
patterns?  And with repeated real file names?  Extending test-walk to
check for these cases would be useful.

Also, the current walk code has a regression: if you give it an exact
name like foo, where foo is not in the dirstate, but is in the ignore
file, it gets ignored but should not be.  This makes it impossible to,
for example, add an ignored file.  Pattern matches should still skip
over such names.

Again, extending test-walk to check for this would be a Good Thing.

Thanks, good stuff there,

	<b



More information about the Mercurial mailing list