[PATCH 5 of 8] Create [web] section with short username as contact on hg init and hg clone

Thomas Arendsen Hein thomas at intevation.de
Sun Aug 28 23:08:02 CDT 2005


* Matt Mackall <mpm at selenic.com> [20050828 22:28]:
> On Sun, Aug 28, 2005 at 06:54:55PM +0200, Thomas Arendsen Hein wrote:
> > # HG changeset patch
> > # User Thomas Arendsen Hein <thomas at intevation.de>
> > # Node ID 899b619a7eb2312d0006ff8120dc3589d865c10c
> > # Parent  92525920ad291a2f9cc9248ac0fef8134f51926b
> > Create [web] section with short username as contact on hg init and hg clone.
> 
> I don't really like this bit. It's going to get it wrong for people
> who haven't set ui.username to what they want yet

It will give the login name or the local part of $EMAIL then, which
I think is a good default. You could also say that it will get wrong
with hg commit and therefore hg commit should bail out if no
ui.username is set.

> and it feels hackish.

Why?

> I also don't want to write more than the bare minimum to this
> file, it sets a bad precedent.

'hg clone' already sets the path, this was the precedent for me.

> I'd rather see us use ui.username as the default contact, and allow
> that to be overridden.

Uh oh, this would be 'nobody' or 'www-something' for many
installations.

I'm still think this is a good idea. Prove me wrong :)

Thomas

-- 
Email: thomas at intevation.de
http://intevation.de/~thomas/


More information about the Mercurial mailing list