csplit support in hg import

Thomas Arendsen Hein thomas at intevation.de
Thu Sep 1 01:44:42 CDT 2005


* TK Soh <teekaysoh at yahoo.com> [20050901 08:08]:
> --- Thomas Arendsen Hein <thomas at intevation.de> wrote:
> > * TK Soh <teekaysoh at yahoo.com> [20050901 02:00]:
> > > All patches can be found in the attached file.
> > 
> > Please use one patch per attachement or one inline patch per mail.
> > 
> > While Matt would prefer the later, I'd prefer the first. I don't
> > know how Bryan thinks about this.
> 
> The patches usually are not directed to any specific developer, I
> feel it'd be tricky to know which practice to follow.

Sure, but if some people like A because of benefit A', accepting
problem A*, and other people like B because of benefit B'. accepting
problem B*, it is not a good idea to send C, which doesn't have
benefit A' and B', but has at least problems B* and C*.

> I guess between you, Bryan and Matt, there need to be some sort of
> guideline to streamline the patch submission process. 

I guess A or B would be ok for Bryan and me and A (inline patches)
are the thing Matt wants, so inline patches are the way to go in the
future. Especially if you only can send attachements as
application/octet-stream, which is not a problem for me, but for
many other people reading here.

> To me, putting all [related] patches in on file would simplify
> code review,

No.

> as it preserves the changesets flow.

Multiple attachements preserve this, too.

Patchbomb mails so it in another way, though they usually don't show
up in the order they were sent, at least for me.

> Besides, it'd be always easier to attach one file vs more.

And it would be easier to omit the changelog message, too.

> Only that right now you will need to split them up before doing
> import.

That's the point. Less work for one person (you), more work for at
least(!) one person (everyone who wants to look at your changesets.

> If this patch does get committed, it should reduce the trouble.

Only the technical trouble of applying this to a repository.

Looking at the patch before applying is still much(!) harder.

Thomas

-- 
Email: thomas at intevation.de
http://intevation.de/~thomas/


More information about the Mercurial mailing list