[patch 2/2] Optimize manifest.add

Bryan O'Sullivan bos at serpentine.com
Thu Sep 1 09:40:41 CDT 2005


On Thu, 2005-09-01 at 09:47 -0400, Chris Mason wrote:

> Testing shows that manifest.add is spending a significant percentage of
> its time running calcoffsets and doing text = "".join(addlist).  This
> patch removes the need for both of these by storying the manifest in a
> character array, and using a modified bisect search to find lines without
> the help of a separate index of line offsets.
> 
> manifest.add was also reworked to push delta construction/combination into the 
> main loop.  

This looks good, but I'm not going to apply it for now.  We'll stay more
focused on things that are either more obvious or bug fixes for the next
few days.

Thanks,

	<b



More information about the Mercurial mailing list