[PATCH] Large clone chewing CPU

Eric Hopper hopper at omnifarious.org
Thu Sep 1 14:35:39 CDT 2005


On Thu, Sep 01, 2005 at 12:02:53PM -0700, Bryan O'Sullivan wrote:
> On Wed, 2005-08-31 at 20:27 -0700, Eric Hopper wrote:
> 
> > The code I put in is a little more complicated than I'd like, but the
> > last patch adds some comments that I hope explain things a bit.
> 
> Please try my change instead, at http://hg.serpentine.com/mercurial/bos
> 
> I've tested it both locally and over http, and it seems to be fine.

Hmmm...

Are you intending 2.3 compatibility, or would requiring Python 2.4 be
OK?  If you don't mind requiring 2.4, then I would use collections.deque
instead of using a standard list.

Also, I think that solves the general problem of having a string you can
append to cheaply, but I think it does so at the expense of some speed
in the specific problem of buffering.

Anyway, all this is a bit moot until I test it to make sure it solves
the speed issue on my repository.

Have fun (if at all possible),
-- 
"It does me no injury for my neighbor to say there are twenty gods or no God.
It neither picks my pocket nor breaks my leg."  --- Thomas Jefferson
"Go to Heaven for the climate, Hell for the company."  -- Mark Twain
-- Eric Hopper (hopper at omnifarious.org  http://www.omnifarious.org/~hopper) --
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.selenic.com/pipermail/mercurial/attachments/20050901/80ac8b5b/attachment.pgp


More information about the Mercurial mailing list