[PATCH 1 of 1] Support for SMTP TLS and login authentication for patchbomb

[Matt Mackall]

On Fri, Sep 09, 2005 at 11:02:19AM -0700, Lee Cantey wrote:
> On 9/9/05, Matt Mackall <mpm at selenic.com> wrote:
> 
> > Tabs are lurking in the above. Please add some sort of documenting
> > comment at the top for this stuff.
> 
> 
> I'm fixing it up now. We use tabs at work (against my will) so they 
> accidentally snuck in.
> 
> Do you have a preference for the new variable names in the smtp section? I 
> thought username and password were pretty obvious but debated among: tls, 
> enabletls, usetls, and encrypted (my favorite this morning).

Don't particularly care about the precise names as it lives in
contrib.

But it does raise an interesting point, which is that the hgrc
namespace needs to be controlled - we need some scheme to keep
extensions and add-ons from polluting the namespace for future core
functionality.

It would seem the sensible thing is for variables added by extensions
or other add-ons to go in a section with the same name as the add-on.
Eg:

[patchbomb]
smtp = foo
usetls = true
...

Or if something needs multiple sections, it can use a prefix:

[patchbomb-smtp]
smtp = foo

[patchbomb-options]
diffstat = true

Extensions are of course free to use existing variables where
appropriate.

Then when we finally add a mail reader to mercurial[1], we won't have
a conflict over this smtp section.

[1] http://catb.org/~esr/jargon/html/Z/Zawinskis-Law.html

> PS. Should I resubmit the whole patch? I'd think so, but I don't know the 
> cleanest way to remove/revert my current one from my repository. 
> Sugggestion?

Looks like Bryan beat you to it.

-- 
Mathematics is the supreme nostalgia of our time.