[PATCH] RE: New standalone Windows release

[Matt Mackall]

On Mon, Sep 26, 2005 at 04:29:02PM -0700, Maquelin, Olivier wrote:
> > From: mercurial-bounces at selenic.com 
> > [mailto:mercurial-bounces at selenic.com] On Behalf Of Zbynek Winkler
> > Sent: Monday, September 26, 2005 5:44 AM
> > To: mercurial at selenic.com
> > Subject: Re: New standalone Windows release
> [...]
> > >If you can make a function that wraps both the select and peek
> > >versions in util.py, I can integrate it.
> > >  
> > >
> > How is this doing? I'd love to see this integrated. I don't 
> > myself use 
> > windows but some of my colleagues do. I've decided to give 
> > mercurial a 
> > shot in our group but for that I need push from windows to work... Is 
> > there any other way except ssh to 'push' that is know to work 
> > on windows?
> 
> We had a piece of code that would allow Windows to work, but I did not
> like it too much. First of all it required Windows-specific code and it
> used win32file and win32pipe, which may not be available on some Python
> installs. It also failed when a password was needed to establish the ssh
> connection. In fact, even under Linux Mercurial would hang when ssh was
> trying to get input from the user (e.g. to confirm a new public key).
> 
> I tried to create a separate thread to handle the error stream, but
> sadly was unable to get that code to work properly. After a while I got
> frustrated with all this and decided that the easiest way to solve the
> problem was to get rid of the "offending code" entirely. After all, the
> only job of the readerr() function is to add the text "remote: " before
> each line coming from the error stream. Maybe we can live without that
> functionality.

I'd rather not. It generates extremely useful output. Can we come up
with a way to isolate the problem code int util.py and then only
Windows folks will be adversely affected?

-- 
Mathematics is the supreme nostalgia of our time.