hgk, Windows and CRLF

Patrick Mézard pmezard at gmail.com
Tue Jun 13 10:31:33 CDT 2006


Hello,

When trying to use hgk (mercurial 0.9) on Windows, comments headlines 
are displayed neither in the changeset treeview nor in the patch 
description. This is clearly a line ending issue: the catcommit function 
in "hgk.py" outputs CRLF terminators to stdout while the Tcl code splits 
using LF only (parsecommit in "hgk" line 197).
Therefore the empty line supposed to separate commit headers from 
comments is detected at the end of the commit info only and the comments 
and headline variables in "hgk" "parsecommit" function are never set.

1- I suppose catcommit output is correct to be in text mode. What do you 
think about it?
2- Assuming [1] it should be really easy to correct the problem using 
something like python splitlinesi instead of "split [...] \n". 
Unfortunately, I am completely clueless about Tcl and failed to find 
such a function. Besides, similar corrections are likely to be needed at 
other places in the code. Could someone provides some help about this?

Thank you,

Patrick Mézard



More information about the Mercurial mailing list