[issue289] mq should create & maintain diffstats in patches

Chris Mason mason at suse.com
Tue Jun 20 07:57:32 CDT 2006


On Sunday 18 June 2006 14:42, Jeremy Fitzhardinge wrote:
> Matt Mackall wrote:
> > I don't know how worthwhile this is. I've personally found them to be
> > a nuisance when revising or committing patches from third parties. The
> > information is already implicit in the patch and most folks can
> > retrieve it with "|diffstat" or equivalent.
>
> I posted a patch to http://www.selenic.com/mercurial/bts/issue289 to
> implement this, at least as far as updating an existing diffstat goes.

I do like the patch, but I'm curious to see if it is measurably slower.  
str.startswith is faster than re in general, so I'm somewhat worried about 
this.

Also, it makes sense to add an hgrc option to diffstat on qrefresh.  Or maybe 
I should implement the hg qedit command people have been asking for to pop up 
the patch in $EDITOR.  We could do hg qedit -d to auto stat it.

Since your fingers are in the code, mq and hg import use different diff 
parsers, which is not a good idea.  Can I talk you into joining them?

-chris


More information about the Mercurial mailing list