[PATCH] Really fix http headers for web UI and issue 254

Eric Hopper hopper at omnifarious.org
Tue Jun 27 14:22:53 CDT 2006


On Tue, Jun 27, 2006 at 03:06:31PM -0300, Alexis S. L. Carvalho wrote:
> Thus spake hopper at omnifarious.org:
> > # HG changeset patch
> > # User Eric Hopper <hopper at omnifarious.org>
> > # Node ID 8e57b5592fbb90519b1ee91bdd345db362f89e32
> > # Parent  e4deeaac5e743ded15ec252b79b27cd48426e963
> > Really fix http headers for web UI and issue 254.
> 
> Getting a raw file is broken (see traceback below).  I think the
> problem here is that the headers for filerevision in the raw style are
> not in the header template (see templates/map-raw).  Also, in this
> particular case, the headers have to be expanded by the templates
> code.

You know, I think I'm just going to have to use util.chunkbuffer for all
of this to make the incoming bunch of pieces from the template look like
a file so I can use mimetools.Message to extract the header from it.
How depressing.

On the plus side, this means I can perhaps just buffer up the whole page
before sending it out, which means I can get a content-length.  Does
anybody think this is an awful idea?  It may cause problems with large
diffs.  But right now the template code returns a whole mass of
recursively nested generators and stuff.  I have no idea if those diffs
are effectively buffered right now or not.

Have fun (if at all possible),
-- 
"It does me no injury for my neighbor to say there are twenty gods or no God.
It neither picks my pocket nor breaks my leg."  --- Thomas Jefferson
"Go to Heaven for the climate, Hell for the company."  -- Mark Twain
-- Eric Hopper (http://www.omnifarious.org/~hopper) --
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.selenic.com/pipermail/mercurial/attachments/20060627/835ab0d1/attachment.pgp


More information about the Mercurial mailing list