[patch] small fix for 'hg tags' on windows

Benoit Boissinot bboissin at gmail.com
Wed May 10 04:09:54 CDT 2006


On 5/10/06, Christian Boos <cboos at neuf.fr> wrote:
> Hi,
>
> I've found a bug on Windows (win32api),
> when I tried to use local tags.
> [snip]
>
> The proposed patch might even fix other similar bugs,
> whenever direct iteration on an posixfile is performed.
>

> +    def __iter__(self):
> +        for line in self.read().split('\n'):

split will remove the '\n' from the line,
self.read().splitlines(True) should be used instead

Can you fix it and resend it ?
Thanks,

Benoit



More information about the Mercurial mailing list