Contrib/Announce: VIM 7.0 plugin for doing 'hg export'ed patch reviews

[Manpreet Singh]

--- Thomas Arendsen Hein <thomas at intevation.de> wrote:

> * Manpreet Singh <junkblocker at yahoo.com> [20060528
> 04:14]:
> > Sure. That sounds great. ThomasAH has a
> hg-menu.vim
> > plugin in contrib too
> 
> hg-menu.vim was written by Steve Borho. Personally I
> don't use menus
> with vim, so it wouldn't be too useful for me.
> 

Ah not sure what made me think it was you. Maybe
misled by the observation that you hang out in #vim :)

> > contrib/vim/patchreview/plugin/pathreview.vim
> > contrib/vim/patchreview/doc/pathreview.txt
> > contrib/vim/hg-menu/plugin/hg-menu.vim
> 
> Hm, maybe creating vimball files (see ":h vimball"
> in vim7) would be
> a good idea.
> 

Yes, that's one of the things I am thinking about with
 0.2 release. See below...

> 
> A small problem: I use an environment where I don't
> always have vim7
> available. You already check for the vim version
> inside
> PatchReview(), but the endfor commands seem to
> confuse vim6.3 and
> 6.4 for a reason unknown to me.
> 
> To circumvent this problem and bail out quietly I've
> added this very
> early to my local copy:
> 
> if v:version < 700
>   finish
> endif
> 

Ah, I thought I had that early in the script but
apparently not. I'll fix it.

> (yes, no error message, all these plugins shouting
> that they don't
> work just because of the old vim version is
> annoying)
> 
> Should I change this in contrib?
> 

Please do so unless you think it's better to wait for
0.2 in a couple of days with

1) GetLatestVimScript support (this is almost free to
add)
2) Possibly vimball support. I am not familiar enough
with it to know if, once converted to vimball, the
script is installable without vimball plugin. Also,
vimball as of a few days ago did not allow picking the
install location e.g. on window it did not let you
choose between $VIM\vimfiles and $HOME\vimfiles.
3) hg diff review support
4) Possible a general scm diff review support (someone
on #vim was already able to use 3) for svn diff
reviews)
5) Documentation update for the above

> Thomas
> 
> P.S.: No comment yet on the usage of the script
> because I didn't use
> it yet, but it looks promising.
> 

> -- 
> Email: thomas at intevation.de
> http://intevation.de/~thomas/
> _______________________________________________
> Mercurial mailing list
> Mercurial at selenic.com
> http://selenic.com/mailman/listinfo/mercurial
> 

Thanks much for the feedback!
-manpreet

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com