bug report: hg addremove -s -n

Thomas Arendsen Hein thomas at intevation.de
Mon Jul 30 10:05:37 CDT 2007


* Matt Mackall <mpm at selenic.com> [20070722 14:59]:
> On Sun, Jul 22, 2007 at 11:52:06AM +0200, Thomas Arendsen Hein wrote:
> > * Dustin Sallings <dustin at spy.net> [20070722 03:37]:
> > > 	The error is telling you that it can't parse -n as a float.  It  
> > > looks like it wants a number as an argument to -s.
> > > 
> > > 	If there's a bug, it's in the help output of ``addremove.''
> > > 
> > > On Jul 21, 2007, at 17:51, Bas van Oostveen wrote:
> > > > # hg addremove -s -n
> > > > ** unknown exception encountered, details follow
> > > > ValueError: invalid literal for float(): -n
> > 
> > Fixed in crew and crew-stable, it now prints:
> > "abort: similarity must be a number"
> > 
> > The other thing is that the help system should have a way to show
> > that some options need a parameter which might have prevented you
> > from omitting the number.
> 
> This bug might have been better fixed by:
> 
> a) teaching fancyopts about floats
> b) teaching fancyopts to complain about conversion failures

That would be nice, but too fancy for -stable.

I have created a feature request for this:
http://www.selenic.com/mercurial/bts/issue661

Thomas

-- 
thomas at intevation.de - http://intevation.de/~thomas/ - OpenPGP key: 0x5816791A
Intevation GmbH, Osnabrueck - Register: Amtsgericht Osnabrueck, HR B 18998
Geschaeftsfuehrer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner


More information about the Mercurial mailing list