Build on Windows: Problem including hgext

[Shun-ichi GOTO]

2007/3/13, Mark <mwatts42 at gmail.com>:
> I am able to successfully build mercurial on windows but the resulting dist
> does not include any of the hgext extentions.

I also found this behaviour before. I guess py2exe cannot detect dependencies
for hgext.* due to current demandimport.
Here is a patch (attached) to force including hgext/*.


But, related with this hgext + py2exe topic, I have an opinion.
I think it is better to install hgext/* files as normal file, not in library.zip
because user can easily add/update extension file.

The users who get hg.exe by installer may get confused how he add new
extensions.
The current answer is:
  Create new directory c:\mercurial\extension (not hgext) and place
your extension
  file there. Then add "extension.myext=" to mercurial.ini.

Current installer does not make extension holder directory like above and
the special name "hgext" direcotry is not allowed because there's already
exist in library.zip and never be used due to namespace issue by loader.
So I think installer should provides standard place or guide to add user's
extension.

One idea is installing hgext/* files as standard file into
"C:\mercurial\hgext\*.py".
There's a benefit to know where he place to and  what extensions are available.
# Attached 2nd patch for InnoSetup script does it, for example.

Another idea is creating empty directory "C:\mercurial\extensions\" for
user own extensions and update document to tell it.

Any opinions?

-- 
Shun-ichi GOTO
-------------- next part --------------
A non-text attachment was scrubbed...
Name: py2exe-force-bundle-hgext
Type: application/octet-stream
Size: 683 bytes
Desc: not available
Url : http://www.selenic.com/pipermail/mercurial/attachments/20070313/02dac0c2/py2exe-force-bundle-hgext.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: install-hgext-not-in-archive
Type: application/octet-stream
Size: 660 bytes
Desc: not available
Url : http://www.selenic.com/pipermail/mercurial/attachments/20070313/02dac0c2/install-hgext-not-in-archive.obj