[PATCH] Add an explicit call to dirstate.write to
debugsetparents.
Alexis S. L. Carvalho
alexis at cecm.usp.br
Mon Mar 19 18:51:16 CDT 2007
Thus spake Nathan Binkert:
> I know this is a way old patch, but I'd like to point out that in the head
> at least, this is necessary if you follow debugsetparents with commit.
> commit might call repo.status() which will overwrite the value that was
> there since it's likely that __del__ will not have happened by then.
I've pushed a fix to crew-stable (and crew) to write the dirstate while
holding the correct lock. Thanks for bringing this up.
> Now, I'll admit that this will only happen if you import
> mercurial.commands and are trying to call one after the other in a python
> script. (I'm trying to make tailor support parents properly.)
It's a bit strange to use commands.debugsetparents - you could just call
dirstate.setparents directly... (while holding the wlock). But if it
works...
Alexis
More information about the Mercurial
mailing list