tag should links to tag name in gitweb

Matt Mackall mpm at selenic.com
Fri Feb 29 15:42:42 CST 2008


On Wed, 2008-02-27 at 16:11 +0800, Weijun Max Wang wrote:
> Hi All
> 
> I like hgweb and find it very useful for code review.
> 
> However, there's a small issue. I'm using mq now. Since the rev id for a
> given patch will change after a qpush/qpop/qrefresh, the changeset URL
> given to the code reviewer changes.
> 
> We know that each mq patch is automatically tagged with its patch name.
> Then, how about let the tags shown on the gitweb page to link to pages
> with the tag name as the rev name? This link will never change as long
> as you do not change the patch name.
> 
> Just make a small change in templates/gitweb/map:
> 
> -tagtag = '<span class="tagtag" title="{name}">{name}</span> '
> +tagtag = '<a href="{url}rev/{name}"><span class="tagtag"
> title="{name}">{name}</span></a> '

Seems reasonable. Care to send a patch, preferably against both styles?

-- 
Mathematics is the supreme nostalgia of our time.



More information about the Mercurial mailing list