https over proxy and other stuff ;)

Chris Morgan mihalis68 at gmail.com
Wed Mar 12 16:17:23 CDT 2008


Hi,
  Is the fix for Hg+https+strict web proxy[1]going to be in 1.0?

Sorry if the answer is obvious to some, it's not to me.

Thanks

Chris

[1] details below, but briefly, using https URLs to access a mercurial
repository via a strict web proxy doesn't work, because strictly
speaking the command sent should be CONNECT, not GET when it's an SSL
connection. The email quoted back below provided the first fix for
this, but I'm not aware that it was accepted




2008/2/6 Chris Li <hg at chrisli.org>:
> On Jan 10, 2008 10:46 AM, Matt Mackall <mpm at selenic.com> wrote:
>
>  > > we tried connection to mercurial via proxy and https. Client connects to proxy
>  > > connection through GET (not connect) so it doesn't work.
>  >
>  > Probably fixable:
>  >
>  >  http://aspn.activestate.com/ASPN/Cookbook/Python/Recipe/456195
>  >
>  > Care to take a stab at it?
>
>  I did take a stab at it. I have one patch for urllib2 and one patch
>  for mercurial.
>  After I apply both I can get mercurial to push over proxy in https.
>
>  I think it is possible to merge the urllib2 patch into mercurial patch as well.
>  keepalive.py has a lot of duplicate of of the urllib2. The proxy_open part
>  of the fix is ugly to integrate to httprepro.py because it is in the middle
>  of the proxy_open function. We have to duplicate the whole proxy_open
>  for it.
>
>  BTW, the reason we need the proxy_open fix is that, http tunnel does not
>  change the request type.  It happens on the socket connection level.
>  It should be transparent to the request once the tunnel is established.
>
>  Chris
>
> _______________________________________________
>  Mercurial mailing list
>  Mercurial at selenic.com
>  http://selenic.com/mailman/listinfo/mercurial
>
>



-- 
test sig


More information about the Mercurial mailing list