Problem with win32text

Alexis S. L. Carvalho alexis at
Tue Mar 18 02:30:27 CDT 2008

Thus spake Shun-ichi GOTO:
> 2008/3/16, Alexis S. L. Carvalho <alexis at>:
> >  I'm not sure what's the right thing to do here.  In the example above,
> >  making the status right after the revert show baz as clean might lead to
> >  fewer surprises.  Hmm...
> I feel it is natural that "hg revert" updates dirstate because:
>  1) What "hg revert" does is "extraction" of file content.
>  2) The eencode/decode is a part of "extraction".
>  3) The encode/decode may not symmetry and may be changed by user.
>  4) It is not strange that dirstate holds informations of most recent
> extraction.

I'm not sure I completely agree with all of this, but I guess updating
the dirstate is the lesser-evil choice.  I've pushed a patch that does

> Is there any reason we should not update dirstate by "revert"?

There were some corner cases (especially during merges) that would be
broken if we just blindly updated the dirstate.  So I had to fix that
before doing this change - which is, of course, a good thing.


More information about the Mercurial mailing list