Bug: hg qnew records outstanding changes desite of not specifying-f

Martin Geisler mg at lazybytes.net
Fri Apr 2 05:18:33 CDT 2010


"Mark Tolonen" <metolone+gmane at gmail.com> writes:

> "Kurt Granroth" <kurt.mercurial at granroth.com> wrote in message
> news:4BB5524B.5030103 at granroth.com...
>> Interesting... I would see that more as an undocumented (or
>> incorrectly documented) feature rather than a bug.  That is, that
>> sequence makes perfect sense to me and acts exactly like I would
>> expect it to.
>>
>> Yet you are right that the docs say otherwise.  The examples on the
>> wiki show otherwise, as well.  I imagine this behavior must have
>> changed recently and the docs were just not updated.
>>
>> So..
>>
>> hg qinit
>> hg qnew patch
>> <edit something>
>> hg qrefresh
>>
>> Can now be done as:
>>
>> <edit something>
>> hg qnew patch
>>
>> No need for qinit and no need for qrefresh.  That's handy to know.
>
> It is working like that in 1.0.1 as well.  -f actually makes more
> sense. You may have forgotten to qrefresh the current patch before
> qnewing the next one, and the previous behavior requiring -f would
> remind you of that fact.
>
> I think it is a bug, not a feature.
>
> <edit something>
> hg qnew patch -f
>
> Isn't much more to type.  Forget it with this "feature" and you'll
> have to qfold to recover if you forgot to qrefresh.

We talked about it at the Paris sprint, and the general agreement was
that none of us had ever done a qnew without -f. The typical workflow
seesm to be:

  hack, hack, hack,
  hq qnew -> error because of modifications
  hg qnew -f

So that is why -f is now the default. I'm sorry we didn't change the
documentation immediatedly. Wagner Bruna sent in a fix yesterday so that
Mercurial 1.5.1 (comes with TortoiseHg 1.0.1) has the updated docs.

-- 
Martin Geisler

Fast and powerful revision control: http://mercurial.selenic.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://selenic.com/pipermail/mercurial/attachments/20100402/80d8489f/attachment.pgp>


More information about the Mercurial mailing list