eol with hg 1.4.x?

Martin Geisler mg at lazybytes.net
Wed Jan 6 07:14:38 CST 2010


Matt Mackall <mpm at selenic.com> writes:

> I don't know what the state of the eol extension is, but it's
> acceptable to add completely new extensions to dot releases, so if
> it's ready, it can go into 1.4.3 on Feb 1.

There are a couple of reasons why I hesitate to declare the extension
done:

* the hooks from win32text have not been re-implemented (the hooks that
  reject bad commits in a central repo). I've not moved the hooks yet
  since I figured it would be easy, but it should still be done.

* the wiki talks about a 'hg eolupdate' command that will help you
  update files to match a changed .hgeol. I'm not sure that is necessary
  after all?

* I have almost no idea about how the dirstate really works and how it
  interacts with the encode/decode filters I use.

  The extension now invalidates entries in the dirstate, but I don't
  know the performance impact of this in a large repository, nor do I
  know if it does it at the correct time.

    http://bitbucket.org/mg/hg-eol/src/tip/eol.py#cl-128

I'm also unsure if this kind of functionality actually belong in the
code instead of in an extension.

Perhaps I'm complicating things too much -- I am happy about the syntax
of the .hgeol file, so in that regard people could begin using the
extension now. Then we'll just have to hope it wont eat too many
repositories and that the tests are doing their job :-)

-- 
Martin Geisler

VIFF (Virtual Ideal Functionality Framework) brings easy and efficient
SMPC (Secure Multiparty Computation) to Python. See: http://viff.dk/.


More information about the Mercurial mailing list