eol with hg 1.4.x?

[Mark Hammond]

On 7/01/2010 12:04 AM, Martin Geisler wrote:
> Mark Hammond<skippy.hammond at gmail.com>  writes:
>
>> On 6/01/2010 11:23 AM, Martin Geisler wrote:
>>> Brett Cannon<brett at python.org>   writes:
>> ...
>>>> I say we make sure the extension is rock-solid and then Python makes
>>>> the switch regardless of what others want in terms of new features.
>>>> The people who brought up this issue have had quite a while to
>>>> follow the work and be active participants.
>>>
>>> Well said :-)
>>
>> I agree with that - the set of *features* required is becoming fairly
>> well defined. What isn't clear yet though is how well things actually
>> work.
>
> Yeah, I've not been good at updating the wiki page. I don't like how it
> has become a big dumping ground for various ideas instead of an actual
> plan that tells us what to implement.
>
> But please look at the tests. That is really where the best
> specification is right now.

Without trying to be pedantic, I expect the tests do indeed cover most 
of the desired functionality, which we seem to agree is in roughly the 
right place.  What the tests obviously do *not* capture are places where 
things don't work quite correctly in practice - as you yourself found in 
the followups.  It is for this reason I was suggesting that nominating a 
date for conversion is premature.

> Clone the repository and run
>
>    make test-eol-clone TESTFLAGS=--debug
>
> to see how a session looks like. Similarly for the other tests:
>
>    http://bitbucket.org/mg/hg-eol/src/tip/tests/

The tests don't seem to run on Windows with my tools.  I've cygwin, so 
'which hg' results in cygwin style paths being specified to Python, 
which doesn't understand such paths.

eg:

% make test-eol-clone TESTFLAGS=--debug
cd tests && python run-tests.py --with-hg=`which hg` --debug test-eol-clone
Usage: run-tests.py [options] [tests]

run-tests.py: error: --with-hg must specify an executable hg script
make: *** [test-eol-clone] Error 2

% which hg
/cygdrive/o/utils/mercurial/hg

I suspect that Python attempts to check the validity of 
'/cygdrive/o/utils/mercurial/hg', which it fails to do.  Or maybe it is 
upset the hg it found isn't a source version?

Either way, trying to move around this I tried executing the 
command-line manually.  Now the output I see is:

Skipped test-eol-clone: shell script
# Ran 1 tests, 1 skipped, 0 failed.

FWIW, I've similar problems with the rest of the hg tests - when I 
submitted a patch to win32text a year or so ago, I was forced to boot up 
a linux box just for the purpose of adjusting and running tests.

> I feel you should be motivated by your *need* for this feature. If you
> or anybody else want it, then join in and help us make it work. Again
> and again I feel like I'm trying to develop a feature that people say is
> important, but nobody is really that much interested anyway.

It is just another chicken-and-egg problem.  Trying to use this 
extension is fairly intrusive in normal work-flows.  I need to make new 
clones of repositories and work inside them.  If I find a problem and 
decide to get some work done without the extension, I'm forced to 
abandon the entire clone, and manually move the work I had done back to 
another copy.  Combine this with the difficulties in testing on Windows 
and the fact noone truly *needs* this anyway (in the same way you don't 
*need* to have your local files in \n format), the barriers to providing 
useful contributions are fairly high.

Cheers,

Mark