Occasional http 500 (KeyError) errors on clone/pull/push

[Matt Mackall]

On Thu, 2013-11-28 at 18:32 +0000, Bruce Cran wrote:
> On 11/28/2013 5:08 PM, Simon King wrote:
> > I'm curious about this comment - old clients should be able to talk to
> > new server versions without problems. Or are you relying on thirdparty
> > extensions which don't work with the newer versions?
> 
> I can't remember the exact problem but upgrading the server from 2.3.2 
> to 2.5.1 caused a problem with subrepos for some people.

That's not likely, nor something anyone else has reported. There has
intentionally never been -any- knowledge of subrepos on the server side,
so it would be hard for a change on the server to break subrepos without
breaking lots of other things.

>  However at that 
> time I was still using hgwebdir.wsgi instead of hgweb.wsgi so maybe that 
> caused the problem?

Definitely not an issue. A copy of hgwebdir.wsgi from the 1.0 era will
still work with the latest hg, you shouldn't need to touch this file
when upgrading.

> > A quick grep of the source code suggests that the 'lheads' command is
> > part of the largefiles extension. Do you have largefiles enabled on
> > some repositories and not others? Perhaps a client using largefiles is
> > somehow connecting to an hgweb instance that isn't configured for it.
> 
> There are a couple of repositories with largefiles enabled, but they 
> aren't the ones being cloned when the error occurs. Could somebody else 
> working with those repositories cause other users' clients to generate 
> errors?

You may be encountering a threading race we haven't seen before. You
should report this in the BTS.

-- 
Mathematics is the supreme nostalgia of our time.