Can't edit commit message by pressing m in 'crecord' interactive mode

Peter Vitt peter.vitt2 at uni-siegen.de
Fri Aug 25 05:04:46 EDT 2017


On 2017-08-24 23:06, Nathan Goldbaum wrote:
> It may be the case that this is a bug. If you can make a test script
> demonstrating the behavior then you should file a bug on mercurial's
> bugzilla.
>

Turns out that this feature wasn't ported to mercurial core.

crecord has a routine to edit the commit message:
<https://bitbucket.org/edgimar/crecord/src/b9bfbcdbc070ede5c66d7494717cdcc0b9f16079/crecord/chunk_selector.py?at=default&fileviewer=file-view-default#chunk_selector.py-925>

However, this routine was not ported to Mercurial when Laurent Charignon
did the initial commit:
<https://www.mercurial-scm.org/repo/hg/file/6409fb6c934d/mercurial/crecord.py>

Also the key handler for the key 'm' as well as the handling of text
prefixed with 'HG:' from crecord's main routine is omitted (the logic is
now in handlekeypressed function). Question is: Is this on purpose?

As the infrastructure to reapply the 'm' key behavior was ported, it is
no big deal to add it again. I can create a patch for that (In fact, I
already did and tested it locally). According to the ContributingChanges
wiki page I think I have to create a bug and later on mail the patch
referring the bug, correct?

Regards, Peter


More information about the Mercurial mailing list