|
Size: 318
Comment:
|
Size: 1862
Comment:
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 1: | Line 1: |
| We're setting up a Phabricator instance to experiment with. When it's ready, we'll add details here. | #pragma section-numbers 2 |
| Line 3: | Line 3: |
| Still to do: | = Phabricator = |
| Line 5: | Line 5: |
| * Herald notifications in plain text * How do we generically send patches to the list, instead of specifying an explicit reviewer? * Patch pushed to -committed should mark as accepted in phab |
<<TableOfContents>> We've set up an instance of [[https://www.phacility.com/phabricator/|Phabricator]] that we're going to experiment with for code reviews. At this time, we're not planning on using any of the other features of Phabricator, and the use of Phabricator for reviews is very much ''an experiment'' - we intend to se how this is going in a little while (probably around the start of the 4.4 cycle). If you're more comfortable submitting and reviewing patches as plain email, that's fine - use of Phabricator is optional. == Registering for an account == To use Phabricator, you can [[https://phab.mercurial-scm.org/auth/start/|log in]] with an existing Google, Facebook, or Bitbucket account, or sign up for a standalone Phabricator account at https://phab.mercurial-scm.org/auth/register/. == Submitting a patch == We've got a [[https://www.mercurial-scm.org/repo/hg/file/tip/contrib/phabricator.py|custom extension]] that should make working with phabricator a little more pleasant. It requires the prerelease of hg 4.3 or later. Our expectation right now is that you'll run tests (as appropriate) and then use {{{hg phabsend}}} to post patches to phabricator. == Accepting a patch == You'll want to use {{{hg phabread}}}, potentially with the {{{--stack}}} flag, for this. Make sure to check that the authorship information is correctly preserved: we've seen some weirdness when people use {{{arc diff}}} instead of {{{hg phabsend}}}. == Phabricator is terrible, I hate it! || Phabricator is awesome, stop using emails! == So is the alternative, just in different ways! But do keep feedback in mind (maybe take notes). We'll probably send around a form to fill in once enough traffic has been run through phabricator to see how people feel about it. ---- CategoryDeveloper |
Phabricator
Contents
We've set up an instance of Phabricator that we're going to experiment with for code reviews. At this time, we're not planning on using any of the other features of Phabricator, and the use of Phabricator for reviews is very much an experiment - we intend to se how this is going in a little while (probably around the start of the 4.4 cycle). If you're more comfortable submitting and reviewing patches as plain email, that's fine - use of Phabricator is optional.
1. Registering for an account
To use Phabricator, you can log in with an existing Google, Facebook, or Bitbucket account, or sign up for a standalone Phabricator account at https://phab.mercurial-scm.org/auth/register/.
2. Submitting a patch
We've got a custom extension that should make working with phabricator a little more pleasant. It requires the prerelease of hg 4.3 or later. Our expectation right now is that you'll run tests (as appropriate) and then use hg phabsend to post patches to phabricator.
3. Accepting a patch
You'll want to use hg phabread, potentially with the --stack flag, for this. Make sure to check that the authorship information is correctly preserved: we've seen some weirdness when people use arc diff instead of hg phabsend.
4. Phabricator is terrible, I hate it! || Phabricator is awesome, stop using emails!
So is the alternative, just in different ways! But do keep feedback in mind (maybe take notes). We'll probably send around a form to fill in once enough traffic has been run through phabricator to see how people feel about it.